Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production 2023-12-18_1 #2256

Merged
merged 1 commit into from
Dec 19, 2023
Merged

production 2023-12-18_1 #2256

merged 1 commit into from
Dec 19, 2023
+456 −187

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Dec 18, 2023

Summary

Add Endpoints for Submitting and Fetching Credentials Based on Request ID (#2183)

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@evq @pavelbrm
Add Endpoints for Submitting and Fetching Credentials Based on Reques…
f188989 
…t ID (#2183)

* add create order item credentials which takes request id

* add endpoint for getting credentials by request id

* Rearrange code in CreateOrderCreds and fix compilation issues

* Tidy up and refactor getOrderCredsByID

* Tidy up and refactor getOrderCredsByID further

* Clean up further GetSigningOrderRequestOutboxByRequestID

* Delete generated garbage

* Fix broken tests

* Undo unrelated changes

* Pass context and database interface to new Datastore method and rename it

* Refactor new Datastore method and rename it to GetTLV2Creds

* Tidy up GetSingleUseCreds

* Tidy up GetSingleUseCreds further

* Undo unrelated changes

* Handle happy path early

* Tidy up GetTimeLimitedCreds

* Dont pass entire order where id is enough

* Clean up GetCredentials and GetItemCredentials

* Add tests for HasItem

---------

Co-authored-by: PavelBrm <[email protected]>
pavelbrm
pavelbrm reviewed Dec 19, 2023
View reviewed changes
services/skus/service.go
Comment on lines +1944 to +1946
func ptrTo[T any](v T) *T {
return &v
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clD11 had removed it in the previous PRs, and I was planning on updating #2183, but it was merged without asking, so it's making a come back.

@husobee husobee merged commit be68ed8 into prod Dec 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@husobee @pavelbrm @evq